fix indent and add spec
stvnrlly
2 changed files with 13 additions and 2 deletions
+ 2
- 2
app/models/agents/slack_agent.rb
@@ -72,9 +72,9 @@ module Agents |
||
| 72 | 72 |
incoming_events.each do |event| |
| 73 | 73 |
opts = interpolated(event) |
| 74 | 74 |
if /^:/.match(opts[:icon]) |
| 75 |
- slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_emoji: opts[:icon] |
|
| 75 |
+ slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_emoji: opts[:icon] |
|
| 76 | 76 |
else |
| 77 |
- slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_url: opts[:icon] |
|
| 77 |
+ slack_notifier.ping opts[:message], channel: opts[:channel], username: opts[:username], icon_url: opts[:icon] |
|
| 78 | 78 |
end |
| 79 | 79 |
end |
| 80 | 80 |
end |
+ 11
- 0
spec/models/agents/slack_agent_spec.rb
@@ -33,6 +33,17 @@ describe Agents::SlackAgent do |
||
| 33 | 33 |
@checker.options['channel'] = nil |
| 34 | 34 |
expect(@checker).not_to be_valid |
| 35 | 35 |
end |
| 36 |
+ |
|
| 37 |
+ it "should allow an icon" do |
|
| 38 |
+ @checker.options['icon_emoji'] = nil |
|
| 39 |
+ expect(@checker).to be_valid |
|
| 40 |
+ @checker.options['icon_emoji'] = ":something:" |
|
| 41 |
+ expect(@checker).to be_valid |
|
| 42 |
+ @checker.options['icon_url'] = "http://something.com/image.png" |
|
| 43 |
+ expect(@checker).to be_valid |
|
| 44 |
+ @checker.options['icon_emoji'] = "something" |
|
| 45 |
+ expect(@checker).to be_valid |
|
| 46 |
+ end |
|
| 36 | 47 |
end |
| 37 | 48 |
|
| 38 | 49 |
describe "#receive" do |